----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1967/#review4599 -----------------------------------------------------------
Ship it! Ship It! - Anthony Gutierrez On Aug. 18, 2013, 3:35 p.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1967/ > ----------------------------------------------------------- > > (Updated Aug. 18, 2013, 3:35 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 9833:926cfdcf6836 > --------------------------- > cpu: Fix timing CPU drain check > > This patch modifies the SimpleTimingCPU drain check to also consider > the fetch event. Previously, there was an assumption that there is > never a fetch event scheduled if the CPU is not executing > microcode. However, when a context is activated, a fetch even is > scheduled, and microPC() is zero. > > > Diffs > ----- > > src/cpu/simple/timing.hh afa9f7f4ee46 > src/cpu/simple/timing.cc afa9f7f4ee46 > > Diff: http://reviews.gem5.org/r/1967/diff/ > > > Testing > ------- > > All regressions pass. The other patch that triggered the assert > now runs without issues. > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
