----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1968/#review4605 -----------------------------------------------------------
Ship it! My guess (without checking) is that the writebacks param is for the old Indirect Index Cache, and is not something any conventional replacement policy would need. I'm fine with getting rid of it; in the (very unlikely) event we need it again, there might be a better way to handle it. - Steve Reinhardt On Aug. 19, 2013, 6:15 a.m., Amin Farmahini wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1968/ > ----------------------------------------------------------- > > (Updated Aug. 19, 2013, 6:15 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > The patch > (1) removes the redundant writeback argument from findVictim() > (2) fixes the description of access() function > > > Diffs > ----- > > src/mem/cache/cache.hh UNKNOWN > src/mem/cache/cache_impl.hh UNKNOWN > src/mem/cache/tags/fa_lru.hh UNKNOWN > src/mem/cache/tags/fa_lru.cc UNKNOWN > src/mem/cache/tags/lru.hh UNKNOWN > src/mem/cache/tags/lru.cc UNKNOWN > > Diff: http://reviews.gem5.org/r/1968/diff/ > > > Testing > ------- > > > Thanks, > > Amin Farmahini > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
