> On Aug. 19, 2013, 9:27 a.m., Andreas Hansson wrote: > > When does this cause a problem? > > Xiangyu Dong wrote: > when switching cpu types, for example functional-->timing
I see the point. If in atomic, then the updateEvent is never scheduled. I'd rather change the drain code to check if updateEvent.scheduled as a separate if block before the retryPkt == NULL. That way it's more clear that the first if-statement is for the case where we come from atomic. It would be good to also add a comment stating this. - Andreas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1969/#review4603 ----------------------------------------------------------- On Aug. 19, 2013, 7:52 a.m., Xiangyu Dong wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1969/ > ----------------------------------------------------------- > > (Updated Aug. 19, 2013, 7:52 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 9824:ac410523ee99 > --------------------------- > cpu: fix bug when TrafficGen deschedules event > > Need to check if an event is scheduled or not before deschedule it during > drain > > > Diffs > ----- > > src/cpu/testers/traffic_gen/traffic_gen.cc afa9f7f4ee46 > > Diff: http://reviews.gem5.org/r/1969/diff/ > > > Testing > ------- > > > Thanks, > > Xiangyu Dong > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
