----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1985/#review4626 -----------------------------------------------------------
Ship it! provided it all works, I'm very happy to see this cleaned up. - Ali Saidi On Aug. 22, 2013, 12:40 a.m., Steve Reinhardt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1985/ > ----------------------------------------------------------- > > (Updated Aug. 22, 2013, 12:40 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 9848:e5971199df65 > --------------------------- > isa: clean up register constants > > Clean up and add some consistency to the *_Base_DepTag > constants as well as some related register constants: > - Get rid of NumMiscArchRegs, TotalArchRegs, and TotalDataRegs > since they're never used and not always defined > - Set FP_Base_DepTag = NumIntRegs when possible (i.e., > every case except x86) > - Set Ctrl_Base_DepTag = FP_Base_DepTag + NumFloatRegs > (this was true before, but wasn't always expressed > that way) > - Drastically reduce the number of arbitrary constants > appearing in these calculations > > > Diffs > ----- > > src/arch/alpha/registers.hh 1ddfb0679c7569fb56382ac2187d6de038fd6f28 > src/arch/arm/registers.hh 1ddfb0679c7569fb56382ac2187d6de038fd6f28 > src/arch/mips/registers.hh 1ddfb0679c7569fb56382ac2187d6de038fd6f28 > src/arch/sparc/miscregs.hh 1ddfb0679c7569fb56382ac2187d6de038fd6f28 > src/arch/sparc/registers.hh 1ddfb0679c7569fb56382ac2187d6de038fd6f28 > src/arch/x86/registers.hh 1ddfb0679c7569fb56382ac2187d6de038fd6f28 > > Diff: http://reviews.gem5.org/r/1985/diff/ > > > Testing > ------- > > > Thanks, > > Steve Reinhardt > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
