----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1960/#review4645 -----------------------------------------------------------
Ship it! Ship It! - Nilay Vaish On Aug. 2, 2013, 8:30 p.m., Joel Hestness wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1960/ > ----------------------------------------------------------- > > (Updated Aug. 2, 2013, 8:30 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 9819:e9d4272fb03f > --------------------------- > config: Initialize and check cpt_starttick > > The previous changeset (9816) that fixes the use of max ticks introduced the > variable cpt_starttick, which is used for setting the relative max tick. > Unfortunately, with checkpointing at an instruction count or with simpoints, > the checkpoint tick is not stored conveniently, so to ensure that > cpt_starttick > is initialized, set it to 0. Also, if using --rel-max-tick, check the use of > instruction counts or simpoints to warn the user that the max tick setting > does > not include the checkpoint ticks. > > > Diffs > ----- > > configs/common/Simulation.py 2492d7ccda7e > > Diff: http://reviews.gem5.org/r/1960/diff/ > > > Testing > ------- > > Tested that max tick specification works when restoring checkpoints collected > using --at-instruction. > > > Thanks, > > Joel Hestness > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
