> On Aug. 30, 2013, 9:01 a.m., Andreas Hansson wrote: > > src/base/statistics.hh, line 337 > > <http://reviews.gem5.org/r/1994/diff/1/?file=37424#file37424line337> > > > > This should be default anyways, why is this needed? > > Nilay Vaish wrote: > I think the constructor: DataWrapVec(const DataWrapVec &ref) > is not there by default. If I add this constructor, then the > constructor DataWrapVec() also needs to be added.
The default copy constructor will do a shallow copy. I don't object to the explicit one, but I don't think it's needed. - Andreas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1994/#review4670 ----------------------------------------------------------- On Sept. 4, 2013, 8:01 p.m., Nilay Vaish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1994/ > ----------------------------------------------------------- > > (Updated Sept. 4, 2013, 8:01 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 9862:f3364571b36c > --------------------------- > ruby: network: convert to gem5 style stats > > > Diffs > ----- > > src/base/statistics.hh e4a4cdfb1b81 > src/mem/ruby/network/Network.hh e4a4cdfb1b81 > src/mem/ruby/network/Network.cc e4a4cdfb1b81 > src/mem/ruby/network/garnet/BaseGarnetNetwork.hh e4a4cdfb1b81 > src/mem/ruby/network/garnet/BaseGarnetNetwork.cc e4a4cdfb1b81 > src/mem/ruby/network/garnet/fixed-pipeline/GarnetNetwork_d.hh e4a4cdfb1b81 > src/mem/ruby/network/garnet/fixed-pipeline/GarnetNetwork_d.cc e4a4cdfb1b81 > src/mem/ruby/network/garnet/fixed-pipeline/InputUnit_d.hh e4a4cdfb1b81 > src/mem/ruby/network/garnet/fixed-pipeline/NetworkLink_d.hh e4a4cdfb1b81 > src/mem/ruby/network/garnet/fixed-pipeline/NetworkLink_d.cc e4a4cdfb1b81 > src/mem/ruby/network/garnet/fixed-pipeline/Router_d.hh e4a4cdfb1b81 > src/mem/ruby/network/garnet/fixed-pipeline/Router_d.cc e4a4cdfb1b81 > src/mem/ruby/network/garnet/fixed-pipeline/VCallocator_d.hh e4a4cdfb1b81 > src/mem/ruby/network/garnet/flexible-pipeline/GarnetNetwork.hh e4a4cdfb1b81 > src/mem/ruby/network/garnet/flexible-pipeline/GarnetNetwork.cc e4a4cdfb1b81 > src/mem/ruby/network/garnet/flexible-pipeline/NetworkLink.hh e4a4cdfb1b81 > src/mem/ruby/network/garnet/flexible-pipeline/NetworkLink.cc e4a4cdfb1b81 > src/mem/ruby/network/orion/NetworkPower.cc e4a4cdfb1b81 > src/mem/ruby/network/simple/PerfectSwitch.hh e4a4cdfb1b81 > src/mem/ruby/network/simple/PerfectSwitch.cc e4a4cdfb1b81 > src/mem/ruby/network/simple/SimpleNetwork.hh e4a4cdfb1b81 > src/mem/ruby/network/simple/SimpleNetwork.cc e4a4cdfb1b81 > src/mem/ruby/network/simple/Switch.hh e4a4cdfb1b81 > src/mem/ruby/network/simple/Switch.cc e4a4cdfb1b81 > src/mem/ruby/network/simple/Throttle.hh e4a4cdfb1b81 > src/mem/ruby/network/simple/Throttle.cc e4a4cdfb1b81 > src/mem/ruby/system/System.hh e4a4cdfb1b81 > src/mem/ruby/system/System.cc e4a4cdfb1b81 > > Diff: http://reviews.gem5.org/r/1994/diff/ > > > Testing > ------- > > > Thanks, > > Nilay Vaish > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
