----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2003/#review4695 -----------------------------------------------------------
Ship it! Thanks for the tweaks! - Steve Reinhardt On Sept. 11, 2013, 8:19 a.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2003/ > ----------------------------------------------------------- > > (Updated Sept. 11, 2013, 8:19 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 9856:5222bd5462f2 > --------------------------- > swig: Fix issue with circular import in 2.0.9/2.0.10 > > This patch fixes an issue which prevented gem5 from running when built > using swig 2.0.9 and 2.0.10. The generated event.py tried to import > m5.internal which in turn relied on importing event. This patch seems > to fix the problem, and so far has not caused any other issues. > > > Diffs > ----- > > src/python/m5/__init__.py a317086a3e19 > src/python/m5/internal/__init__.py a317086a3e19 > > Diff: http://reviews.gem5.org/r/2003/diff/ > > > Testing > ------- > > Built on Ubuntu 10.04, RHE5, Fedora 19, Fedora RawHide, OpenSuse 12.3, OSX > 10.8, with clang 3.2, 3.3, gcc 4.7, 4.8 and swig 2.0.4 and 2.0.9 and 2.0.10 > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
