> On Sept. 19, 2013, 1:11 a.m., Steve Reinhardt wrote: > > src/cpu/kvm/x86_cpu.cc, line 355 > > <http://reviews.gem5.org/r/2012/diff/1/?file=37560#file37560line355> > > > > This function name is pretty ambiguous... how about > > isCanonicalSegBase()?
I'm renaming it to isCanonicalAddress() since it is more general than segment base addresses. I'm also adding a comment to explain what a canonical address is. - Andreas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2012/#review4710 ----------------------------------------------------------- On Sept. 10, 2013, 3:35 p.m., Andreas Sandberg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2012/ > ----------------------------------------------------------- > > (Updated Sept. 10, 2013, 3:35 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 9872:9328d4f007cb > --------------------------- > kvm: Add x86 segment register verification to help debugging > > *** > This patch is a part of series of changes to add support for KVM on x86. See > https://github.com/andysan/gem5/tree/kvm-x86 for the full series. > > > Diffs > ----- > > src/cpu/kvm/x86_cpu.cc PRE-CREATION > > Diff: http://reviews.gem5.org/r/2012/diff/ > > > Testing > ------- > > > Thanks, > > Andreas Sandberg > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
