----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2021/#review4721 -----------------------------------------------------------
I do not really see the point here. Could you be more clear around what this "integration" would involve? In any case, I would vote not to include the McPat source in gem5, and if it really needs to live in the source tree, get the users that want to have it to clone/checkout in ext/mcpat. - Andreas Hansson On Sept. 20, 2013, 1:34 a.m., Anthony Gutierrez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2021/ > ----------------------------------------------------------- > > (Updated Sept. 20, 2013, 1:34 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 9883:e04afe3402d5 > --------------------------- > ext: add McPAT source > > this adds the source for mcpat, a power, area, and timing modeling framework. > this will allow for the future integration of mcpat into gem5. > > > Diffs > ----- > > ext/mcpat/ExampleResults/ARM_A9_2000 PRE-CREATION > ext/mcpat/ExampleResults/ARM_A9_2000_withIOC PRE-CREATION > ext/mcpat/ExampleResults/Alpha21364 PRE-CREATION > ext/mcpat/ExampleResults/Penryn PRE-CREATION > ext/mcpat/ExampleResults/T1 PRE-CREATION > ext/mcpat/ExampleResults/T1_DC_64 PRE-CREATION > ext/mcpat/ExampleResults/T1_SBT_64 PRE-CREATION > ext/mcpat/ExampleResults/T1_ST_64 PRE-CREATION > ext/mcpat/ExampleResults/T2 PRE-CREATION > ext/mcpat/ExampleResults/Xeon PRE-CREATION > ext/mcpat/ProcessorDescriptionFiles/ARM_A9_2000.xml PRE-CREATION > ext/mcpat/ProcessorDescriptionFiles/ARM_A9_2000_withIOC.xml PRE-CREATION > ext/mcpat/ProcessorDescriptionFiles/Alpha21364.xml PRE-CREATION > ext/mcpat/ProcessorDescriptionFiles/Niagara1.xml PRE-CREATION > ext/mcpat/ProcessorDescriptionFiles/Niagara1_sharing_DC.xml PRE-CREATION > ext/mcpat/ProcessorDescriptionFiles/Niagara1_sharing_SBT.xml PRE-CREATION > ext/mcpat/ProcessorDescriptionFiles/Niagara1_sharing_ST.xml PRE-CREATION > ext/mcpat/ProcessorDescriptionFiles/Niagara2.xml PRE-CREATION > ext/mcpat/ProcessorDescriptionFiles/Penryn.xml PRE-CREATION > ext/mcpat/ProcessorDescriptionFiles/Xeon.xml PRE-CREATION > ext/mcpat/README PRE-CREATION > ext/mcpat/XML_Parse.h PRE-CREATION > ext/mcpat/XML_Parse.cc PRE-CREATION > ext/mcpat/arch_const.h PRE-CREATION > ext/mcpat/array.h PRE-CREATION > ext/mcpat/array.cc PRE-CREATION > ext/mcpat/basic_components.h PRE-CREATION > ext/mcpat/basic_components.cc PRE-CREATION > ext/mcpat/cacti/README PRE-CREATION > ext/mcpat/cacti/Ucache.h PRE-CREATION > ext/mcpat/cacti/Ucache.cc PRE-CREATION > ext/mcpat/cacti/arbiter.h PRE-CREATION > ext/mcpat/cacti/arbiter.cc PRE-CREATION > ext/mcpat/cacti/area.h PRE-CREATION > ext/mcpat/cacti/area.cc PRE-CREATION > ext/mcpat/cacti/bank.h PRE-CREATION > ext/mcpat/cacti/bank.cc PRE-CREATION > ext/mcpat/cacti/basic_circuit.h PRE-CREATION > ext/mcpat/cacti/basic_circuit.cc PRE-CREATION > ext/mcpat/cacti/cache.cfg PRE-CREATION > ext/mcpat/cacti/cacti.mk PRE-CREATION > ext/mcpat/cacti/cacti_interface.h PRE-CREATION > ext/mcpat/cacti/cacti_interface.cc PRE-CREATION > ext/mcpat/cacti/component.h PRE-CREATION > ext/mcpat/cacti/component.cc PRE-CREATION > ext/mcpat/cacti/const.h PRE-CREATION > ext/mcpat/cacti/contention.dat PRE-CREATION > ext/mcpat/cacti/crossbar.h PRE-CREATION > ext/mcpat/cacti/crossbar.cc PRE-CREATION > ext/mcpat/cacti/decoder.h PRE-CREATION > ext/mcpat/cacti/decoder.cc PRE-CREATION > ext/mcpat/cacti/htree2.h PRE-CREATION > ext/mcpat/cacti/htree2.cc PRE-CREATION > ext/mcpat/cacti/io.h PRE-CREATION > ext/mcpat/cacti/io.cc PRE-CREATION > ext/mcpat/cacti/main.cc PRE-CREATION > ext/mcpat/cacti/makefile PRE-CREATION > ext/mcpat/cacti/mat.h PRE-CREATION > ext/mcpat/cacti/mat.cc PRE-CREATION > ext/mcpat/cacti/nuca.h PRE-CREATION > ext/mcpat/cacti/nuca.cc PRE-CREATION > ext/mcpat/cacti/parameter.h PRE-CREATION > ext/mcpat/cacti/parameter.cc PRE-CREATION > ext/mcpat/cacti/powergating.h PRE-CREATION > ext/mcpat/cacti/powergating.cc PRE-CREATION > ext/mcpat/cacti/router.h PRE-CREATION > ext/mcpat/cacti/router.cc PRE-CREATION > ext/mcpat/cacti/subarray.h PRE-CREATION > ext/mcpat/cacti/subarray.cc PRE-CREATION > ext/mcpat/cacti/technology.cc PRE-CREATION > ext/mcpat/cacti/uca.h PRE-CREATION > ext/mcpat/cacti/uca.cc PRE-CREATION > ext/mcpat/cacti/version_cacti.h PRE-CREATION > ext/mcpat/cacti/wire.h PRE-CREATION > ext/mcpat/cacti/wire.cc PRE-CREATION > ext/mcpat/core.h PRE-CREATION > ext/mcpat/core.cc PRE-CREATION > ext/mcpat/globalvar.h PRE-CREATION > ext/mcpat/interconnect.h PRE-CREATION > ext/mcpat/interconnect.cc PRE-CREATION > ext/mcpat/iocontrollers.h PRE-CREATION > ext/mcpat/iocontrollers.cc PRE-CREATION > ext/mcpat/logic.h PRE-CREATION > ext/mcpat/logic.cc PRE-CREATION > ext/mcpat/main.cc PRE-CREATION > ext/mcpat/makefile PRE-CREATION > ext/mcpat/mcpat.mk PRE-CREATION > ext/mcpat/memoryctrl.h PRE-CREATION > ext/mcpat/memoryctrl.cc PRE-CREATION > ext/mcpat/noc.h PRE-CREATION > ext/mcpat/noc.cc PRE-CREATION > ext/mcpat/processor.h PRE-CREATION > ext/mcpat/processor.cc PRE-CREATION > ext/mcpat/sharedcache.h PRE-CREATION > ext/mcpat/sharedcache.cc PRE-CREATION > ext/mcpat/version.h PRE-CREATION > ext/mcpat/xmlParser.h PRE-CREATION > ext/mcpat/xmlParser.cc PRE-CREATION > > Diff: http://reviews.gem5.org/r/2021/diff/ > > > Testing > ------- > > > Thanks, > > Anthony Gutierrez > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
