----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2017/#review4740 -----------------------------------------------------------
Ship it! Looks fine other than the comment. No need to post for re-review on my account, if you want to just add the comment and commit. src/cpu/kvm/base.cc <http://reviews.gem5.org/r/2017/#comment4493> A brief comment explaining the purpose of this function would be nice (esp. since the only usage I see is 1000 lines away). - Steve Reinhardt On Sept. 19, 2013, 8:57 a.m., Andreas Sandberg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2017/ > ----------------------------------------------------------- > > (Updated Sept. 19, 2013, 8:57 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 9888:0bdbf5b24c62 > --------------------------- > kvm: Add support for thread-specific instruction events > > Instruction events are currently ignored when executing in KVM. This > changeset adds support for triggering KVM exits based on instruction > counts using hardware performance counters. Depending on the > underlying performance counter implementation, there might be some > inaccuracies due to instructions being counted in the host kernel when > entering/exiting KVM. > > Due to limitations/bugs in Linux's performance counter interface, we > can't reliably change the period of an overflow counter. We work > around this issue by detaching and reattaching the counter if we need > to reconfigure it. > > > Diffs > ----- > > src/cpu/kvm/base.hh 372d3611c693 > src/cpu/kvm/base.cc 372d3611c693 > > Diff: http://reviews.gem5.org/r/2017/diff/ > > > Testing > ------- > > > Thanks, > > Andreas Sandberg > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
