----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2027/#review4753 -----------------------------------------------------------
Ship it! Ship It! - Ali Saidi On Sept. 28, 2013, 2:15 a.m., Steve Reinhardt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2027/ > ----------------------------------------------------------- > > (Updated Sept. 28, 2013, 2:15 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 9895:478cbab633ed > --------------------------- > scons: fix minor update-ref bug in regressions > > In the unusual case that regressions are run with --update-ref > when there is no existing regression output, scons gets > confused because it depends on stats.txt to trigger the > update, but it has no indication that running the test will > generate the stats.txt file. (In the typical case where > stats.txt already exists, scons doesn't care about where > it came from.) > > It's easy to fix this just by adding the stats.txt file > to the target list for the test action. > > > Diffs > ----- > > tests/SConscript d1a5e147e72db4c64f7d489bb14069c62215471a > > Diff: http://reviews.gem5.org/r/2027/diff/ > > > Testing > ------- > > > Thanks, > > Steve Reinhardt > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
