> On Sept. 30, 2013, 6:42 p.m., Andreas Sandberg wrote: > > This isn't an ideal solution since we could run on 2.6.32 kernels (although > > drainnig wouldn't be completely reliable). Anyway, push this change to get > > things rolling again. > > > > A better long-term solution would be to include the header in the source > > (that's what qemu does), but there might be licensing issues preventing us > > from doing that.
I am mostly surprised to see that the KVM_API_VERSION (that comes with a nice comment stating that it should be updated on API changes) does not seem to have been changed since pre 2.6...despite numerous changes :-) I don't think it is a big problem that we gate the KVM work on kernels after 2.6.35, which effectively is what this check does. - Andreas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2029/#review4754 ----------------------------------------------------------- On Sept. 30, 2013, 5:34 p.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2029/ > ----------------------------------------------------------- > > (Updated Sept. 30, 2013, 5:34 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 9899:d1c321ce2faf > --------------------------- > kvm: Only include KVM support for supported kernels > > This patch adds a check to ensure that the KVM API provided by the > running kernel is what we are expecting. > > > Diffs > ----- > > SConstruct 2935441b0870 > > Diff: http://reviews.gem5.org/r/2029/diff/ > > > Testing > ------- > > Now works again on Ubuntu 10.04. > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
