----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2030/#review4758 -----------------------------------------------------------
Ship it! LGTM. Haven't been able to reproduce the error though. - Andreas Sandberg On Oct. 1, 2013, 12:10 p.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2030/ > ----------------------------------------------------------- > > (Updated Oct. 1, 2013, 12:10 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 9899:d23589f0026f > --------------------------- > ext: Fix fputils compiler flags to ensure ISO C99 > > The fp code relies on C99, and depending on gcc version, the default > is to use c89. This patch adds -std=c99 when using gcc to ensure the > code is compiled in ISO C99 mode. > > > Diffs > ----- > > ext/fputils/SConscript 2935441b0870 > > Diff: http://reviews.gem5.org/r/2030/diff/ > > > Testing > ------- > > Tested with RHE5, Ubuntu 10.04, OpenSuse 12.3 and Fedora Rawhide. > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
