> On Sept. 29, 2013, 2:15 a.m., Joel Hestness wrote: > > I've had a personal patch for a while that comments out the code you're > > eliminating here, and I sympathize with wanting to eliminate this to ease > > regression parsing. I've always wondered why we even print a version of > > this data to the stats.txt and not just a separate file for > > simulator-specific data (i.e. separate from simulated system statistics). > > That would completely eliminate the non-deterministic stats problem. > > > > Minor comment below, but otherwise, this looks good to me.
I'd like to put a vote in for removing the men-usage, simulation speed etc from the stats.txt. Let's just print this out the stdout (simout) rather. Thoughts? - Andreas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2028/#review4752 ----------------------------------------------------------- On Sept. 28, 2013, 2:18 a.m., Steve Reinhardt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2028/ > ----------------------------------------------------------- > > (Updated Sept. 28, 2013, 2:18 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 9896:dae3245884f3 > --------------------------- > ruby: eliminate non-determinism from ruby.stats output > > Get rid of non-deterministic "stats" in ruby.stats output > such as time & date of run, elapsed & CPU time used, > and memory usage. These values cause spurious > miscomparisons when looking at output diffs (though > they don't affect regressions, since the regressions > pass/fail status currently ignores ruby.stats entirely). > > Most of this information is already captured in other > places (time & date in stdout, elapsed time & mem usage > in stats.txt), where the regression script is smart > enough to filter it out. It seems easier to get rid of > the redundant output rather than teaching the > regression tester to ignore the same information in > two different places. > > > Diffs > ----- > > src/mem/ruby/profiler/Profiler.cc d1a5e147e72db4c64f7d489bb14069c62215471a > src/mem/ruby/system/System.cc d1a5e147e72db4c64f7d489bb14069c62215471a > > Diff: http://reviews.gem5.org/r/2028/diff/ > > > Testing > ------- > > > Thanks, > > Steve Reinhardt > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
