----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2035/#review4767 -----------------------------------------------------------
Ship it! LGTM - Ali Saidi On Oct. 7, 2013, 2:12 p.m., Andreas Sandberg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2035/ > ----------------------------------------------------------- > > (Updated Oct. 7, 2013, 2:12 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 9906:a64f74eb0d5a > --------------------------- > base: Clean up signal handling > > The PollEvent class dynamically installs a SIGIO and SIGALRM handler > when a file handler is registered. Most signal handlers currently get > registered in the initSignals() function. This changeset moves the > SIGIO/SIGALRM handlers to initSignals() to live with the other signal > handlers. The original code installs SIGIO and SIGALRM with the > SA_RESTART option to prevent syscalls from returning EINTR. This > changeset consistently uses this flag for all signal handlers to > ensure that other signals that trigger asynchronous behavior (e.g., > statistics dumping) do not cause undesirable EINTR returns. > > > Diffs > ----- > > src/base/pollevent.hh 2a7c8ec11cff > src/base/pollevent.cc 2a7c8ec11cff > src/cpu/kvm/base.cc 2a7c8ec11cff > src/sim/init.cc 2a7c8ec11cff > > Diff: http://reviews.gem5.org/r/2035/diff/ > > > Testing > ------- > > Ran on x86 with KVM. Verified that asynchronous sockets work (terminal). > > > Thanks, > > Andreas Sandberg > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
