----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2034/#review4769 -----------------------------------------------------------
Ship it! Ship It! - Ali Saidi On Oct. 7, 2013, 11:50 a.m., Andreas Sandberg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2034/ > ----------------------------------------------------------- > > (Updated Oct. 7, 2013, 11:50 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 9906:6908b72f1ffa > --------------------------- > mem: Rename the ASI_BITS flag field in Request > > ASI_BITS in the Request object were originally used to store a memory > request's ASI on SPARC. This is not the case any more since other ISAs > use the ASI bits to store architecture-dependent information. This > changeset renames the ASI_BITS to ARCH_BITS which better describes > their use. Additionally, the getAsi() accessor is renamed to > getArchFlags(). > > > Diffs > ----- > > src/arch/sparc/tlb.cc e672a39fd426 > src/mem/request.hh e672a39fd426 > > Diff: http://reviews.gem5.org/r/2034/diff/ > > > Testing > ------- > > Quick regressions for ARM, SPARC, MIPS, X86 pass with the exception of the > insttest and m5threads tests on SPARC (missing binaries). > > > Thanks, > > Andreas Sandberg > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
