----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2058/#review4775 -----------------------------------------------------------
Thanks for looking into this. I don't really have a strong opinion about the comments below, fix them if you agree, otherwise, just push the change anyway. src/python/m5/simulate.py <http://reviews.gem5.org/r/2058/#comment4500> This should be in a separate commit. tests/configs/switcheroo.py <http://reviews.gem5.org/r/2058/#comment4499> Could you make this a keyword argument (defaulting to false) to run_test instead? That would allow us to just bind that argument when setting up individual test cases. - Andreas Sandberg On Oct. 16, 2013, 6:45 p.m., Steve Reinhardt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2058/ > ----------------------------------------------------------- > > (Updated Oct. 16, 2013, 6:45 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 9925:a0361278e9b6 > --------------------------- > tests: suppress output on switcheroo tests > > The output from the switcheroo tests is voluminous and > (because it includes timestamps) highly sensitive to > minor changes, leading to extremely large updates to the > reference outputs. This patch addresses this problem > by suppressing output from the tests. An internal > variable can be set to enable the output. Wiring that > up to a command-line parameter (perhaps even the > rudimantary -v/-q options in m5/main.py). > > > Diffs > ----- > > src/python/m5/simulate.py 31ef410b6843521775bf0deea42a41a206496037 > tests/configs/switcheroo.py 31ef410b6843521775bf0deea42a41a206496037 > > Diff: http://reviews.gem5.org/r/2058/diff/ > > > Testing > ------- > > > Thanks, > > Steve Reinhardt > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
