----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2061/#review4780 -----------------------------------------------------------
Looks OK, but should be two separate commits since it fixes two different problems. I'm happy to let the virtualization hack (why did it break non-virtualized systems?) go, we should probably switch to a memory mapped solution instead which wouldn't require a patched kernel. - Andreas Sandberg On Oct. 17, 2013, 6:57 p.m., Ali Saidi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2061/ > ----------------------------------------------------------- > > (Updated Oct. 17, 2013, 6:57 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 9867:55af621f65df > --------------------------- > arm: fix m5ops binary for ARM and add m5fail. > > Changes to make m5ops work under virtualization seemed to break them working > with non-virtualized systems and the recently added m5 fail command makes > the m5op binary not compile. For now remove the code for virtualization. > > > Diffs > ----- > > util/m5/m5.c 13ffc0066b76 > util/m5/m5op_arm.S 13ffc0066b76 > > Diff: http://reviews.gem5.org/r/2061/diff/ > > > Testing > ------- > > > Thanks, > > Ali Saidi > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
