----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2066/#review4782 -----------------------------------------------------------
Ship it! LGTM. We might want to do the same cleanup in some of the other pipeline components as well. - Andreas Sandberg On Oct. 17, 2013, 6:58 p.m., Ali Saidi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2066/ > ----------------------------------------------------------- > > (Updated Oct. 17, 2013, 6:58 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 9872:004a962d4cfb > --------------------------- > cpu: Construct ROB with cpu params struct instead of each variable > > Most other structures/stages get passed the cpu params struct. > > > Diffs > ----- > > src/cpu/o3/cpu.cc 13ffc0066b76 > src/cpu/o3/rob.hh 13ffc0066b76 > src/cpu/o3/rob_impl.hh 13ffc0066b76 > > Diff: http://reviews.gem5.org/r/2066/diff/ > > > Testing > ------- > > > Thanks, > > Ali Saidi > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
