----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2063/#review4784 -----------------------------------------------------------
Ship it! LGTM. You might want to make get() const as well. - Andreas Sandberg On Oct. 17, 2013, 6:57 p.m., Ali Saidi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2063/ > ----------------------------------------------------------- > > (Updated Oct. 17, 2013, 6:57 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 9869:f654fee8faf7 > --------------------------- > mem: Add "const" attribute to Packet getters > > Add a "const" keywords to the getters in the Packet class so these can be > invoked on const Packet objects. > > > Diffs > ----- > > src/mem/packet.hh 13ffc0066b76 > > Diff: http://reviews.gem5.org/r/2063/diff/ > > > Testing > ------- > > > Thanks, > > Ali Saidi > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
