> On Sept. 18, 2013, 6:39 p.m., Nilay Vaish wrote: > > Any comments? I am planning to commit it on Friday. > > Andreas Hansson wrote: > Do any regressions change? > > Would it be an option to change the aforementioned functionality so that > what ever is causing the issue does not happen in startup (but rather > unserialize I would imagine)?
While it seems to me that we can move ruby's startup code to the unserialize() function, I don't know if calling simulate() while objects are still being unserialized is a proper thing. - Nilay ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2005/#review4697 ----------------------------------------------------------- On Sept. 10, 2013, 12:35 a.m., Nilay Vaish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2005/ > ----------------------------------------------------------- > > (Updated Sept. 10, 2013, 12:35 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 9868:112a9778300a > --------------------------- > sim: reset stats after startup > Currently statistics are reset after the initial / checkpoint state > has been loaded. But ruby does some checkpoint processing in its > startup() function. So the stats need to be reset after the startup() > function has been called. This patch moves the class to stats.reset() > to achieve this change in functionality. > > > Diffs > ----- > > src/python/m5/simulate.py cc5797147e1c > > Diff: http://reviews.gem5.org/r/2005/diff/ > > > Testing > ------- > > > Thanks, > > Nilay Vaish > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
