On Mon, 25 Nov 2013, Andreas Hansson wrote:

Hi Nilay,

I¹m not 100% convinced I agree with this change. Isn¹t the floor just as
right/wrong as the ceil?

I don't think so. Here is a piece of code:

src/mem/cache/cache_impl.hh:721:        lat += 
ticksToCycles(memSidePort->sendAtomic(bus_pkt));

I think the author of that line would prefer ceil over floor. And I think for all the other 14 places where ticksToCycles() is in use, ceil is preferable.


More importantly, does this not change regressions?


Well, I have not tried running regressions. I do expect them to change, not by much though.

--
Nilay
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev

Reply via email to