> On Jan. 6, 2014, 1:32 a.m., Steve Reinhardt wrote: > > I'd like to understand a little better exactly what problem this is > > solving. Like Ali, I'm sort of concerned about exposing something like > > this unless it's really necessary. For example, if you want to move > > curTick() ahead to a certain point, you can always to that by scheduling an > > event. I can believe that that's not the most convenient thing, but I'd > > like to be convinced that it's so inconvenient that this function really is > > necessary before we add this method.
I'm trying to get the unit tests to compile. Since curTick(newVal) has been removed, I needed another way to set the tick value for the current queue. I've updated review request #2133. Now stattest works without adding a setCurTick function in core. So, if you accept #2133, this patch is no longer needed. Should I close it? - Ola ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2135/#review4857 ----------------------------------------------------------- On Dec. 28, 2013, 7:37 p.m., Ola Jeppsson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2135/ > ----------------------------------------------------------- > > (Updated Dec. 28, 2013, 7:37 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10004:7c8348d23222 > --------------------------- > sim: core: add setCurTick() function > Add setCurTick() function that sets the simulation clock for the current > event queue to the specified value. > --- > src/sim/core.hh | 3 +++ > 1 file changed, 3 insertions(+) > > This is needed for a patch I have to make unittest:stattest work again. > > > Diffs > ----- > > src/sim/core.hh 4b872fdba3af > > Diff: http://reviews.gem5.org/r/2135/diff/ > > > Testing > ------- > > > Thanks, > > Ola Jeppsson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
