> On Dec. 14, 2013, 7:25 p.m., Joel Hestness wrote: > > .hgignore, line 12 > > <http://reviews.gem5.org/r/2116/diff/1/?file=38431#file38431line12> > > > > I understand that as a stop-gap, McPAT will need to use a separate > > build process from gem5. However, until the gem5 community really commits > > to tightening integration with McPAT, it feels unsettling to have to > > clutter the gem5 .hgignore file for its inclusion (as an extra). Maybe I'm > > just advocating for adding .hgignore comments that reflect this is a > > stop-gap solution, but I also describe a couple alternative routes below, > > which would feel much better to me. > > > > > > Depending on the expected longer-term direction with McPAT, I'd prefer > > something other than modifying the .hgignore. A couple other options: > > > > (1) If the plan is to have McPAT build separately from gem5 (i.e. > > outside of scons), then maybe we could set the default McPAT configuration > > build-prefix to be under the gem5/build/ directory, which is already > > included in the .hgignore > > > > (2) If the plan is to build McPAT as an optional extra or tightly > > integrated with gem5 simulation (i.e. completely within scons), then we > > could (will) add the appropriate SConscript files to gem5/ext/mcpat/ to do > > the build within gem5/build/ > > > > Brad Beckmann wrote: > It appears that no other binaries built under ext/ are handled by the > .hgignore file, correct? Is that is because no other ext directory generates > as many files as McPAT or is it that all other ext directories generate all > their files underneath the gem5/build directory? > > Assuming I completely understand the issues here, I certainly would > rather see this patch check in than not. I strong suspect most other users > would feel the same once they start using McPAT. I agree with Joel that the > best solution would be for McPAT to generate all it's files underneath the > build directory. How much work would that involve? > >
I think it really needs to generate all it's files in the build directory. Thanks, ali - Ali ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2116/#review4828 ----------------------------------------------------------- On Dec. 11, 2013, 10:33 p.m., Yasuko Eckert wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2116/ > ----------------------------------------------------------- > > (Updated Dec. 11, 2013, 10:33 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 9995:f98f3226b908 > --------------------------- > ext: hgignore files for McPAT > Add more McPAT files and directories to be ignored. > Both ext/mcpat/obj_opt and ext/mcpat/obj_dbg will contain object files > for McPAT. > > > Diffs > ----- > > .hgignore bdd606534bdc6526758135fce0416544db27afc0 > > Diff: http://reviews.gem5.org/r/2116/diff/ > > > Testing > ------- > > > Thanks, > > Yasuko Eckert > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
