----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2151/#review4884 -----------------------------------------------------------
Looks good to me... just the one minor change below and I'm fine. I'm assuming mcpat is typically built separately from gem5? If not, and if we wanted to be fancy, we could put a rule in the SConstruct file that invokes make, passing in the proper value for BUILD_DIR... but that seems cute but unnecessary to me. ext/mcpat/makefile <http://reviews.gem5.org/r/2151/#comment4557> Someone might be using an alternate build directory, so it would be good to let them override that from the command line. You could do this: BUILD_DIR ?= ../../build ODIR = $(BUILD_DIR)/mcpat - Steve Reinhardt On Jan. 21, 2014, 5:35 p.m., Yasuko Eckert wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2151/ > ----------------------------------------------------------- > > (Updated Jan. 21, 2014, 5:35 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 9995:1b0426ea7377 > --------------------------- > ext: Redirect McPAT object files > All object files and McPAT binaries are moved to directory gem5/build/mcpat/ > rather than creating them locally. > > > Diffs > ----- > > ext/mcpat/makefile PRE-CREATION > ext/mcpat/mcpat.mk PRE-CREATION > > Diff: http://reviews.gem5.org/r/2151/diff/ > > > Testing > ------- > > > Thanks, > > Yasuko Eckert > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
