changeset 1548b7aa657c in /z/repo/gem5
details: http://repo.gem5.org/gem5?cmd=changeset;node=1548b7aa657c
description:
mem: Remove redundant findVictim() input argument
The patch
(1) removes the redundant writeback argument from findVictim()
(2) fixes the description of access() function
Committed by: Nilay Vaish <[email protected]>
diffstat:
src/mem/cache/cache.hh | 2 +-
src/mem/cache/cache_impl.hh | 2 +-
src/mem/cache/tags/fa_lru.cc | 2 +-
src/mem/cache/tags/fa_lru.hh | 3 +--
src/mem/cache/tags/lru.cc | 2 +-
src/mem/cache/tags/lru.hh | 3 +--
6 files changed, 6 insertions(+), 8 deletions(-)
diffs (80 lines):
diff -r f11b4c0e52f8 -r 1548b7aa657c src/mem/cache/cache.hh
--- a/src/mem/cache/cache.hh Tue Jan 28 18:00:49 2014 -0600
+++ b/src/mem/cache/cache.hh Tue Jan 28 18:00:50 2014 -0600
@@ -195,9 +195,9 @@
/**
* Does all the processing necessary to perform the provided request.
* @param pkt The memory request to perform.
+ * @param blk The cache block to be updated.
* @param lat The latency of the access.
* @param writebacks List for any writebacks that need to be performed.
- * @param update True if the replacement data should be updated.
* @return Boolean indicating whether the request was satisfied.
*/
bool access(PacketPtr pkt, BlkType *&blk,
diff -r f11b4c0e52f8 -r 1548b7aa657c src/mem/cache/cache_impl.hh
--- a/src/mem/cache/cache_impl.hh Tue Jan 28 18:00:49 2014 -0600
+++ b/src/mem/cache/cache_impl.hh Tue Jan 28 18:00:50 2014 -0600
@@ -1192,7 +1192,7 @@
Cache<TagStore>::allocateBlock(Addr addr, bool is_secure,
PacketList &writebacks)
{
- BlkType *blk = tags->findVictim(addr, writebacks);
+ BlkType *blk = tags->findVictim(addr);
if (blk->isValid()) {
Addr repl_addr = tags->regenerateBlkAddr(blk->tag, blk->set);
diff -r f11b4c0e52f8 -r 1548b7aa657c src/mem/cache/tags/fa_lru.cc
--- a/src/mem/cache/tags/fa_lru.cc Tue Jan 28 18:00:49 2014 -0600
+++ b/src/mem/cache/tags/fa_lru.cc Tue Jan 28 18:00:50 2014 -0600
@@ -224,7 +224,7 @@
}
FALRUBlk*
-FALRU::findVictim(Addr addr, PacketList &writebacks)
+FALRU::findVictim(Addr addr)
{
FALRUBlk * blk = tail;
assert(blk->inCache == 0);
diff -r f11b4c0e52f8 -r 1548b7aa657c src/mem/cache/tags/fa_lru.hh
--- a/src/mem/cache/tags/fa_lru.hh Tue Jan 28 18:00:49 2014 -0600
+++ b/src/mem/cache/tags/fa_lru.hh Tue Jan 28 18:00:50 2014 -0600
@@ -203,10 +203,9 @@
/**
* Find a replacement block for the address provided.
* @param pkt The request to a find a replacement candidate for.
- * @param writebacks List for any writebacks to be performed.
* @return The block to place the replacement in.
*/
- FALRUBlk* findVictim(Addr addr, PacketList & writebacks);
+ FALRUBlk* findVictim(Addr addr);
void insertBlock(PacketPtr pkt, BlkType *blk);
diff -r f11b4c0e52f8 -r 1548b7aa657c src/mem/cache/tags/lru.cc
--- a/src/mem/cache/tags/lru.cc Tue Jan 28 18:00:49 2014 -0600
+++ b/src/mem/cache/tags/lru.cc Tue Jan 28 18:00:50 2014 -0600
@@ -172,7 +172,7 @@
}
LRU::BlkType*
-LRU::findVictim(Addr addr, PacketList &writebacks)
+LRU::findVictim(Addr addr)
{
unsigned set = extractSet(addr);
// grab a replacement candidate
diff -r f11b4c0e52f8 -r 1548b7aa657c src/mem/cache/tags/lru.hh
--- a/src/mem/cache/tags/lru.hh Tue Jan 28 18:00:49 2014 -0600
+++ b/src/mem/cache/tags/lru.hh Tue Jan 28 18:00:50 2014 -0600
@@ -169,10 +169,9 @@
/**
* Find a block to evict for the address provided.
* @param addr The addr to a find a replacement candidate for.
- * @param writebacks List for any writebacks to be performed.
* @return The candidate block.
*/
- BlkType* findVictim(Addr addr, PacketList &writebacks);
+ BlkType* findVictim(Addr addr);
/**
* Insert the new block into the cache. For LRU this means inserting into
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev
