----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2161/#review4903 -----------------------------------------------------------
I don't follow your rationale, but I don't see any harm in what you're doing either... but I think you're doing it awkwardly ;-). src/dev/SConscript <http://reviews.gem5.org/r/2161/#comment4570> If you want these files to be compiled in unconditionally, why not just list them once above the if instead of listing them twice? - Steve Reinhardt On Feb. 13, 2014, 6:39 a.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2161/ > ----------------------------------------------------------- > > (Updated Feb. 13, 2014, 6:39 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10065:573eff8aee0c > --------------------------- > dev: Include basic devices in NULL ISA build > > This patch enbles use of the basic PIO devices as part of the NULL > build. Although it might seem counter intuitive to have a PIO device > without being able to execute a driver, this change enables us to > break a device class hierarchy into an ISA-agnostic part, and an > ISA-specific part, without requiring multiple-inheritance. The > ISA-agnostic base class is a PIO device, but does not make use of the > port. > > > Diffs > ----- > > src/dev/SConscript 3b0d0c988ed6 > src/dev/baddev.cc 3b0d0c988ed6 > > Diff: http://reviews.gem5.org/r/2161/diff/ > > > Testing > ------- > > All regressions pass > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
