----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2159/#review4910 -----------------------------------------------------------
Ship it! It looks like I was asking for a few clarifications in the commit message, but that's it. I think the code itself is good to go. I don't want to halt your momentum on this :) - Steve Reinhardt On Feb. 10, 2014, 1:45 a.m., Andreas Sandberg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2159/ > ----------------------------------------------------------- > > (Updated Feb. 10, 2014, 1:45 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10062:4fea5050f4f2 > --------------------------- > kvm: Add support for multi-system simulation > > The introduction of parallel event queues added most of the support > needed to run multiple VMs (systems) within the same gem5 > instance. This changeset fixes up signal delivery so that KVM's > control signals are delivered to the thread that executes the CPU's > event queue. > > There are currently no facilities to multiplex between multiple KVM > CPUs in the same event queue, we are therefore limited to > configurations where there is only one KVM CPU per event queue. In > practice, this means that multi-system configurations can be > simulated, but not multiple CPUs in a shared-memory configuration. > > > Diffs > ----- > > src/cpu/kvm/base.hh 3b0d0c988ed6 > src/cpu/kvm/base.cc 3b0d0c988ed6 > src/cpu/kvm/timer.cc 3b0d0c988ed6 > > Diff: http://reviews.gem5.org/r/2159/diff/ > > > Testing > ------- > > Tested boot and interactive use of single CPU system -- works. > Tested boot of dual-system configuration and interactive use -- works. > > Did not run regressions as the current tests do not test KVM functionality. > > Also available from the multisys branch in git://github.com/andysan/gem5.git. > > > Thanks, > > Andreas Sandberg > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
