----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2165/ -----------------------------------------------------------
Review request for Default. Repository: gem5 Description ------- Changeset 10079:1b871a9a8277 --------------------------- mem: Edit proto Packet and enhance the python script This patch changes the decode script to output the optional fields of the proto message Packet, namely id and flags. The flags field is set by the communication monitor. The id field is useful for CPU trace experiments, e.g. linking the fetch side to decode side. It had to be renamed because it clashes with a built in python function id() for getting the "identity" of an object. This patch also takes a few common function definitions out from the multiple scripts and adds them to a protolib python module. Diffs ----- src/proto/packet.proto 2360411a16be util/decode_packet_trace.py 2360411a16be util/encode_packet_trace.py 2360411a16be util/protolib.py PRE-CREATION Diff: http://reviews.gem5.org/r/2165/diff/ Testing ------- All regressions pass. Note that we have _not_ updated the version number (given that this field was optional, and most likely not widely used). Thanks, Andreas Hansson _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
