----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2174/#review4920 -----------------------------------------------------------
src/cpu/pred/bi_mode.cc <http://reviews.gem5.org/r/2174/#comment4576> Can you explain what these constants are? How did you choose them? Since you are using these in the update function as well, I suggest that you create a separate function for computing the global history index and call that function from lookup() and update(). - Nilay Vaish On Feb. 21, 2014, 10:19 p.m., Anthony Gutierrez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2174/ > ----------------------------------------------------------- > > (Updated Feb. 21, 2014, 10:19 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10085:eab454da79a5 > --------------------------- > cpu: implement a bi-mode branch predictor > > this patch implements the bi-mode branch predictor as described in: > > Lee et al. The Bi-Mode Branch Predictor. MICRO 30. 1997 > > > Diffs > ----- > > src/cpu/o3/fetch_impl.hh 2beea2a439b43bf95bc040198322d4869b07f4f3 > src/cpu/pred/BranchPredictor.py 2beea2a439b43bf95bc040198322d4869b07f4f3 > src/cpu/pred/SConscript 2beea2a439b43bf95bc040198322d4869b07f4f3 > src/cpu/pred/bi_mode.hh PRE-CREATION > src/cpu/pred/bi_mode.cc PRE-CREATION > src/cpu/pred/bpred_unit.hh 2beea2a439b43bf95bc040198322d4869b07f4f3 > src/cpu/pred/bpred_unit.cc 2beea2a439b43bf95bc040198322d4869b07f4f3 > > Diff: http://reviews.gem5.org/r/2174/diff/ > > > Testing > ------- > > > Thanks, > > Anthony Gutierrez > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
