changeset 5be102721895 in /z/repo/gem5
details: http://repo.gem5.org/gem5?cmd=changeset;node=5be102721895
description:
        ruby: profiler: statically allocate stats variable
        Couple of users observed segmentation fault when the simulator tries to
        register the statistical variable m_IncompleteTimes.  It seems that 
there
        is some problem with the initialization of these variables when 
allocated
        in the constructor.

diffstat:

 src/mem/ruby/profiler/Profiler.cc |  1 -
 src/mem/ruby/profiler/Profiler.hh |  2 +-
 2 files changed, 1 insertions(+), 2 deletions(-)

diffs (23 lines):

diff -r 9c55c0214404 -r 5be102721895 src/mem/ruby/profiler/Profiler.cc
--- a/src/mem/ruby/profiler/Profiler.cc Mon Feb 24 20:50:06 2014 -0600
+++ b/src/mem/ruby/profiler/Profiler.cc Sat Mar 01 23:35:21 2014 -0600
@@ -62,7 +62,6 @@
 using m5::stl_helpers::operator<<;
 
 Profiler::Profiler(const RubySystemParams *p)
-    : m_IncompleteTimes(MachineType_NUM)
 {
     m_hot_lines = p->hot_lines;
     m_all_instructions = p->all_instructions;
diff -r 9c55c0214404 -r 5be102721895 src/mem/ruby/profiler/Profiler.hh
--- a/src/mem/ruby/profiler/Profiler.hh Mon Feb 24 20:50:06 2014 -0600
+++ b/src/mem/ruby/profiler/Profiler.hh Sat Mar 01 23:35:21 2014 -0600
@@ -125,7 +125,7 @@
     std::vector<Stats::Histogram *> m_InitialToForwardDelayHist;
     std::vector<Stats::Histogram *> m_ForwardToFirstResponseDelayHist;
     std::vector<Stats::Histogram *> m_FirstResponseToCompletionDelayHist;
-    std::vector<Stats::Scalar> m_IncompleteTimes;
+    Stats::Scalar m_IncompleteTimes[MachineType_NUM];
 
     //added by SS
     bool m_hot_lines;
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev

Reply via email to