----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2175/#review4943 -----------------------------------------------------------
If there are no objections I'll go ahead and push this in the next few days. - Andreas Hansson On Feb. 26, 2014, 10:52 a.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2175/ > ----------------------------------------------------------- > > (Updated Feb. 26, 2014, 10:52 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10098:a11f79b70e42 > --------------------------- > mem: Fix incorrect assert failure in the Cache > > This patch fixes an assert condition that is not true at all > times. There are valid situations that arise in dual-core > dual-workload runs where the assert condition is false. The function > call following the assert however needs to be called only when the > condition is true (a block cannot be invalidated in the tags structure > if has not been allocated in the structure, and the tempBlock is never > allocated). Hence the 'assert' has been replaced with an 'if'. > > > Diffs > ----- > > src/mem/cache/cache_impl.hh d76312a74915 > > Diff: http://reviews.gem5.org/r/2175/diff/ > > > Testing > ------- > > All regressions pass > > Previously failing dual-core runs work without issues > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
