----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2204/#review4975 -----------------------------------------------------------
Ship it! Seems like a nice simplification. configs/example/fs.py <http://reviews.gem5.org/r/2204/#comment4587> what if it is not alpha or x86? - Andreas Hansson On March 12, 2014, 6:51 p.m., Nilay Vaish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2204/ > ----------------------------------------------------------- > > (Updated March 12, 2014, 6:51 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10113:2de5a0712b10 > --------------------------- > config: remove ruby_fs.py > > The patch removes the ruby_fs.py file. The functionality is being moved to > fs.py. This would being ruby fs simulations in line with how ruby se > simulations are started (using --ruby option). The alpha fs config functions > are being combined for classing and ruby memory systems. This required > renaming the piobus in ruby to iobus. So, we will have stats being renamed > in the stats file for ruby fs regression. > > > Diffs > ----- > > configs/common/FSConfig.py fd90d9e55e5c > configs/example/fs.py fd90d9e55e5c > configs/example/ruby_fs.py fd90d9e55e5c > configs/example/se.py fd90d9e55e5c > configs/ruby/MESI_Two_Level.py fd90d9e55e5c > configs/ruby/Ruby.py fd90d9e55e5c > tests/configs/pc-simple-timing-ruby.py fd90d9e55e5c > > Diff: http://reviews.gem5.org/r/2204/diff/ > > > Testing > ------- > > > Thanks, > > Nilay Vaish > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
