> On March 12, 2014, 2:59 a.m., Amin Farmahini wrote: > > I am not opposed to this patch, but I would keep it as SimpleDRAM until we > > support more fine grained timing parameters such as tCCD and tWR. On the > > other hand, it is not that of a simple model any more, so it is not a bad > > idea for marketing purposes. > > Andreas Hansson wrote: > If you're ok with it, I would propose to go ahead and this point. I agree > that tWR and tCCD should be high on the priority list. Any volunteers? :-)
Sounds good to me. Regarding tWR and tCCD, I'll put them in my todo list for summer :). - Amin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2200/#review4966 ----------------------------------------------------------- On March 7, 2014, 11:47 p.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2200/ > ----------------------------------------------------------- > > (Updated March 7, 2014, 11:47 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10121:3f0e8a243002 > --------------------------- > mem: Rename SimpleDRAM to a more suitable DRAMCtrl > > This patch renames the not-so-simple SimpleDRAM to a more suitable > DRAMCtrl. The name change is intended to ensure that we do not send > the wrong message (although the "simple" in SimpleDRAM was originally > intended as in cleverly simple, or elegant). > > As the DRAM controller modelling work is being presented at ISPASS'14 > our hope is that a broader audience will use the model in the future. > > > Diffs > ----- > > configs/common/MemConfig.py 580b47334a97 > configs/dram/sweep.py PRE-CREATION > src/mem/DRAMCtrl.py PRE-CREATION > src/mem/SConscript 580b47334a97 > src/mem/SimpleDRAM.py 580b47334a97 > src/mem/dram_ctrl.hh PRE-CREATION > src/mem/dram_ctrl.cc PRE-CREATION > src/mem/simple_dram.hh 580b47334a97 > src/mem/simple_dram.cc 580b47334a97 > > Diff: http://reviews.gem5.org/r/2200/diff/ > > > Testing > ------- > > All regressions pass > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
