changeset c4d058c993bf in /z/repo/gem5
details: http://repo.gem5.org/gem5?cmd=changeset;node=c4d058c993bf
description:
mem: Fix bug in DRAM bytes per activate
This patch ensures that we do not sample the bytes per activate when
the row has already been closed.
diffstat:
src/mem/simple_dram.cc | 21 +++++++++++++++++----
1 files changed, 17 insertions(+), 4 deletions(-)
diffs (45 lines):
diff -r 9d44ba8964a5 -r c4d058c993bf src/mem/simple_dram.cc
--- a/src/mem/simple_dram.cc Sun Mar 23 11:12:03 2014 -0400
+++ b/src/mem/simple_dram.cc Sun Mar 23 11:12:05 2014 -0400
@@ -1066,7 +1066,6 @@
// Update bank state
if (pageMgmt == Enums::open || pageMgmt == Enums::open_adaptive) {
- bank.openRow = dram_pkt->row;
bank.freeAt = curTick() + addDelay + accessLat;
// If you activated a new row do to this access, the next access
@@ -1077,9 +1076,18 @@
bank.tRASDoneAt = actTick + tRAS;
recordActivate(actTick, dram_pkt->rank, dram_pkt->bank);
- // sample the number of bytes accessed and reset it as
- // we are now closing this row
- bytesPerActivate.sample(bank.bytesAccessed);
+ // if we closed an open row as a result of this access,
+ // then sample the number of bytes accessed before
+ // resetting it
+ if (bank.openRow != -1)
+ bytesPerActivate.sample(bank.bytesAccessed);
+
+ // update the open row
+ bank.openRow = dram_pkt->row;
+
+ // start counting anew, this covers both the case when we
+ // auto-precharged, and when this access is forced to
+ // precharge
bank.bytesAccessed = 0;
bank.rowAccesses = 0;
}
@@ -1137,6 +1145,11 @@
DPRINTF(DRAM, "All banks precharged at tick: %ld\n",
startTickPrechargeAll);
}
+
+ // sample the bytes per activate here since we are closing
+ // the page
+ bytesPerActivate.sample(bank.bytesAccessed);
+
DPRINTF(DRAM, "Auto-precharged bank: %d\n", dram_pkt->bankId);
}
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev