----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2219/ -----------------------------------------------------------
Review request for Default. Repository: gem5 Description ------- Changeset 10151:5b91be92fdd2 --------------------------- ruby: slicc: change enqueue statement As of now, the enqueue statement can take in any number of 'pairs' as argument. But we only use the pair in which latency is the key. This latency is allowed to be either a fixed integer or a member variable of controller in which the expression appears. This patch drops the use of pairs in an enqueue statement. Instead, an expression is allowed which will be interpreted to be the latency of the enqueue. This expression can anything allowed by slicc including a constant integer or a member variable. Diffs ----- src/mem/protocol/MESI_Three_Level-L0cache.sm 45a67d84fd4a src/mem/protocol/MESI_Three_Level-L1cache.sm 45a67d84fd4a src/mem/protocol/MESI_Two_Level-L1cache.sm 45a67d84fd4a src/mem/protocol/MESI_Two_Level-L2cache.sm 45a67d84fd4a src/mem/protocol/MESI_Two_Level-dir.sm 45a67d84fd4a src/mem/protocol/MESI_Two_Level-dma.sm 45a67d84fd4a src/mem/protocol/MI_example-cache.sm 45a67d84fd4a src/mem/protocol/MI_example-dir.sm 45a67d84fd4a src/mem/protocol/MI_example-dma.sm 45a67d84fd4a src/mem/protocol/MOESI_CMP_directory-L1cache.sm 45a67d84fd4a src/mem/protocol/MOESI_CMP_directory-L2cache.sm 45a67d84fd4a src/mem/protocol/MOESI_CMP_directory-dir.sm 45a67d84fd4a src/mem/protocol/MOESI_CMP_directory-dma.sm 45a67d84fd4a src/mem/protocol/MOESI_CMP_token-L1cache.sm 45a67d84fd4a src/mem/protocol/MOESI_CMP_token-L2cache.sm 45a67d84fd4a src/mem/protocol/MOESI_CMP_token-dir.sm 45a67d84fd4a src/mem/protocol/MOESI_CMP_token-dma.sm 45a67d84fd4a src/mem/protocol/MOESI_hammer-cache.sm 45a67d84fd4a src/mem/protocol/MOESI_hammer-dir.sm 45a67d84fd4a src/mem/protocol/MOESI_hammer-dma.sm 45a67d84fd4a src/mem/protocol/Network_test-cache.sm 45a67d84fd4a src/mem/slicc/ast/EnqueueStatementAST.py 45a67d84fd4a src/mem/slicc/parser.py 45a67d84fd4a Diff: http://reviews.gem5.org/r/2219/diff/ Testing ------- Thanks, Nilay Vaish _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
