----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2221/ -----------------------------------------------------------
Review request for Default. Repository: gem5 Description ------- Changeset 10154:4a788c919b4e --------------------------- dev: Protect PollEvent processing when running in parallel mode The calling thread is undefined when the PollQueue services events. This implies that PollEvents need to handle the case where they are processed from a different thread than the thread that created the event. This changeset adds temporary event queue migrations to the VNC server, the ethernet tap device, and the terminal to protect them from inter-thread calls. Diffs ----- src/base/vnc/vncserver.cc 936a3a8006f6 src/dev/ethertap.cc 936a3a8006f6 src/dev/terminal.cc 936a3a8006f6 Diff: http://reviews.gem5.org/r/2221/diff/ Testing ------- Interactive tests with the multi-(CPU|core) KVM implementation, simulation gets very aborts/deadlocks without the patch. Compiles for ARM & X86 targets. This changeset is not expected to affect regressions since they don't test the IO poll queue. Thanks, Andreas Sandberg _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
