----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2224/#review5004 -----------------------------------------------------------
configs/topologies/Cluster.py <http://reviews.gem5.org/r/2224/#comment4595> Can you explain the reason for this change in more detail? The way we use this topology (in gem5-gpu) is like this: gpu_cluster = Cluster() for i in xrange(number of CUs): ... gpu_cluster.add(l1_cntrl) And similarly for the CPU cluster. At a minimum, could you change this so that controllers defaults to the empty list? This way current code which uses the cluster topology will still work. - Jason Power On April 10, 2014, 2:31 a.m., Malek Musleh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2224/ > ----------------------------------------------------------- > > (Updated April 10, 2014, 2:31 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10158:6e2ebdf2e286 > --------------------------- > ruby: cluster topology config fix > > > Diffs > ----- > > configs/topologies/Cluster.py 5c2ecad1a3c9 > src/mem/ruby/slicc_interface/AbstractController.hh 5c2ecad1a3c9 > > Diff: http://reviews.gem5.org/r/2224/diff/ > > > Testing > ------- > > > Thanks, > > Malek Musleh > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
