-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2227/#review5017
-----------------------------------------------------------



src/sim/syscallreturn.hh
<http://reviews.gem5.org/r/2227/#comment4599>

    If you're cleaning this up, why bother to continue storing success?


- Nathan Binkert


On April 21, 2014, 7:15 p.m., Steve Reinhardt wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/2227/
> -----------------------------------------------------------
> 
> (Updated April 21, 2014, 7:15 p.m.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> -------
> 
> Changeset 10162:5cfa2de6a6f6
> ---------------------------
> syscall emulation: clean up & comment SyscallReturn
> 
> 
> Diffs
> -----
> 
>   src/arch/alpha/process.cc ae43fc4d78cbf8190838147190c2009a9811f175 
>   src/arch/arm/process.cc ae43fc4d78cbf8190838147190c2009a9811f175 
>   src/arch/mips/process.cc ae43fc4d78cbf8190838147190c2009a9811f175 
>   src/arch/power/process.cc ae43fc4d78cbf8190838147190c2009a9811f175 
>   src/arch/sparc/process.cc ae43fc4d78cbf8190838147190c2009a9811f175 
>   src/arch/x86/process.cc ae43fc4d78cbf8190838147190c2009a9811f175 
>   src/sim/syscall_emul.cc ae43fc4d78cbf8190838147190c2009a9811f175 
>   src/sim/syscallreturn.hh ae43fc4d78cbf8190838147190c2009a9811f175 
> 
> Diff: http://reviews.gem5.org/r/2227/diff/
> 
> 
> Testing
> -------
> 
> passes se/quick tests other than 70.tgen, which shouldn't matter
> 
> 
> Thanks,
> 
> Steve Reinhardt
> 
>

_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev

Reply via email to