----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2288/#review5131 -----------------------------------------------------------
Ship it! Ship It! - Ali Saidi On June 7, 2014, 10 p.m., Joel Hestness wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2288/ > ----------------------------------------------------------- > > (Updated June 7, 2014, 10 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10237:8dca2b118862 > --------------------------- > Util: Do not style check symlinks > > The style checker used to traverse symlinks if they pointed to files, which > can > result in style checker failure if the pointed-to file doesn't exist. This > style check is actually unnecessary, since symlinks either point to other > files > that are already style checked, or files outside gem5, which shouldn't be > checked. Skip symlinks. > > > Diffs > ----- > > util/style.py 0db28826e333 > > Diff: http://reviews.gem5.org/r/2288/diff/ > > > Testing > ------- > > Context: The scons implementation of gem5 regressions is pretty clunky and > rigid; > When implementing gem5-style regressions for gem5-gpu, the gem5 regressions > structure requires that we do one of the following: > 1) Store and update regressions outputs in a patch on gem5 (YUCK!) > 2) Replicate some test/ subdirectories across gem5 and gem5-gpu (undesirable) > 3) Use a symlink from gem5 into gem5-gpu (currently most preferred) > Currently, symlinks can cause the style check to fail despite not even > needing to > check them. > > We have verified that this patch correctly skips checking symlinks. > > > Thanks, > > Joel Hestness > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
