----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2292/#review5144 -----------------------------------------------------------
Why is Addr being parsed using toMemorySize() in the first place? That seems wrong. At least some of the places Addr is used with a size (like RealView.max_mem_size), I think the problem is that the param should really be a Param.MemorySize to begin with. - Steve Reinhardt On June 12, 2014, 3:47 p.m., Ali Saidi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2292/ > ----------------------------------------------------------- > > (Updated June 12, 2014, 3:47 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10240:d4f21d820604 > --------------------------- > python: Change parsing of Addr so hex values work from scripts > > When passed from a configuration script with a hexadecimal value (like > "0x80000000"), gem5 would error out. This is because it would call > "toMemorySize" which requires the argument to end with a size specifier (like > 1MB, etc). > > This modification makes it so raw hex values can be passed through Addr > parameters from the configuration scripts. > > > Diffs > ----- > > src/arch/arm/ArmSystem.py a2bb75a474fd > src/python/m5/params.py a2bb75a474fd > > Diff: http://reviews.gem5.org/r/2292/diff/ > > > Testing > ------- > > > Thanks, > > Ali Saidi > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
