----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2294/#review5147 -----------------------------------------------------------
Ship it! Minor comment below is just optional. src/arch/isa_parser.py <http://reviews.gem5.org/r/2294/#comment4677> Not a big deal, but I'd use None rather than the empty string here to make it clear that it's unset. Could even skip this line entirely and use "hasattr(self, 'op_class')" below, but that's overkill IMO. - Steve Reinhardt On June 12, 2014, 3:47 p.m., Ali Saidi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2294/ > ----------------------------------------------------------- > > (Updated June 12, 2014, 3:47 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10249:73d1e7e4bfff > --------------------------- > arch: Properly guess OpClass from optional StaticInst flags > > isa_parser.py guesses the OpClass if none were given based upon the StaticInst > flags. The existing code does not take into account optionally set flags. > This code hoists the setting of optional flags so OpClass is properly > assigned. > > > Diffs > ----- > > src/arch/isa_parser.py a2bb75a474fd > > Diff: http://reviews.gem5.org/r/2294/diff/ > > > Testing > ------- > > > Thanks, > > Ali Saidi > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
