> On July 2, 2014, 12:08 a.m., Steve Reinhardt wrote: > > src/base/inet.hh, line 101 > > <http://reviews.gem5.org/r/2304/diff/1/?file=40127#file40127line101> > > > > seems like it would be more consistent with the other code to do a loop > > up to ETH_ADDR_LEN, but this works too.
fixed - Anthony ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2304/#review5174 ----------------------------------------------------------- On July 2, 2014, 3:51 p.m., Anthony Gutierrez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2304/ > ----------------------------------------------------------- > > (Updated July 2, 2014, 3:51 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10250:177ddbf6d5cd > --------------------------- > base: fix some bugs in EthAddr > > per the IEEE 802 spec: > 1) fixed broadcast() to ensure that all bytes are equal to 0xff. > 2) fixed unicast() to ensure that bit 0 of the first byte is equal to 0 > 3) fixed multicast() to ensure that bit 0 of the first byte is equal to 1, and > that it is not a broadcast. > > also the constructors in EthAddr are fixed so that all bytes of data are > initialized. > > > Diffs > ----- > > src/base/inet.hh 6bbb7ae309accedfb251aae3c4095acd6b57832d > src/base/inet.cc 6bbb7ae309accedfb251aae3c4095acd6b57832d > > Diff: http://reviews.gem5.org/r/2304/diff/ > > > Testing > ------- > > > Thanks, > > Anthony Gutierrez > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
