----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2306/#review5179 -----------------------------------------------------------
Ship it! Ship It! - Ali Saidi On July 3, 2014, 5:12 p.m., Steve Reinhardt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2306/ > ----------------------------------------------------------- > > (Updated July 3, 2014, 5:12 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10252:62ffe6aa9285 > --------------------------- > syscall emulation: fix DPRINTF arg ordering bug > > When we switched getSyscallArg() from explicit arg indices to > the implicit method, some DPRINTF arguments were left as calls > to getSyscallArg(), even though C/C++ doesn't guarantee > anything about the order of invocation of these calls. As a > result, the args could be printed out in arbitrary orders. > > Interestingly, this bug has been around since 2009: > http://repo.gem5.org/gem5/rev/4842482e1bd1 > > > Diffs > ----- > > src/sim/syscall_emul.cc 878f2f30b12d38f619b80b5d80d52498946f6ad1 > > Diff: http://reviews.gem5.org/r/2306/diff/ > > > Testing > ------- > > > Thanks, > > Steve Reinhardt > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
