----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2310/#review5180 -----------------------------------------------------------
Ship it! Thanks for chasing this down - Andreas Hansson On July 7, 2014, 9:52 p.m., Anthony Gutierrez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2310/ > ----------------------------------------------------------- > > (Updated July 7, 2014, 9:52 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10252:4ef536dde28a > --------------------------- > base: fix operator== for comparing EthAddr objects > > this operator uses memcmp() to detect if two EthAddr object have the same > address, however memcmp() will return 0 if all bytes are equal. operator== > returns the return value of memcmp() to indicate whether or not two > address are equal. this is incorrect as it will always give the opposite of > the intended behavior. this patch fixes that problem. > > > Diffs > ----- > > src/base/inet.cc 878f2f30b12d38f619b80b5d80d52498946f6ad1 > > Diff: http://reviews.gem5.org/r/2310/diff/ > > > Testing > ------- > > regressions now pass > > > Thanks, > > Anthony Gutierrez > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
