> On May 4, 2014, 11:56 p.m., Steve Reinhardt wrote: > > src/python/m5/SimObject.py, line 654 > > <http://reviews.gem5.org/r/2246/diff/1/?file=39624#file39624line654> > > > > This seems kind of complicated, but I'm going to wait for a > > higher-level description of what it's doing before I dig into it. > > Geoffrey Blake wrote: > The intent is that you can build a configuration system that exposes all > params to be settable on the command line (instead of the tiny fraction > available now) and a system that auto-updates its available settable command > line flags whenever a simobject's params are edited. The other intention of > this function is to provide the argument parser with enough information about > each parameter to make unique command lines, and also use the ParamValue > itself as an input check to catch any errors in specifying a command as early > as possible. > > The enumerateParams() function takes a simobject instance and traces out > all the reachable parameters it contains and constructs information to be > presented on the command line. For example, if you passed an instance of > O3_ARM_v7a_3 to enumerateParams() it will generate command lines to be > presented such as: > --testsys-cpucluster-O3_ARM_v7a_3.branchPred.BTBTagSize > --testsys-cpucluster-O3_ARM_v7a_3.fuPool.FUList0.count > --testsys-cpucluster-O3_ARM_v7a_3.LQEntries > > > > > Steve Reinhardt wrote: > OK, I see. So I take it there's some additional code needed in > se.py/fs.py/etc. to make this work? Would it make sense to include that in > this patch, so people can see how to use it? > > Geoffrey Blake wrote: > There is a large chunk code that is a full top to bottom re-write of the > mainline configuration scripts, so it wouldn't make much sense to include in > this patch. > > Steve Reinhardt wrote: > OK. Are you intending to commit that separately then?
Yes, but the timeline is tbd. - Ali ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2246/#review5082 ----------------------------------------------------------- On April 23, 2014, 12:22 p.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2246/ > ----------------------------------------------------------- > > (Updated April 23, 2014, 12:22 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10198:f749128e94c8 > --------------------------- > config: Add hooks to enable new config sys > > This patch adds helper functions to SimObject.py, params.py and > simulate.py to enable the new configuration system. Functions like > enumerateParams() in SimObject lets the config system auto-generate > command line options for simobjects to be modified on the command > line. > > Params in params.py have __call__() added > to their definition to allow the argparse module to use them > as a type to check command input is in the proper format. > > simulate.py is changed to allow for empty simobjects to exist in the hierarchy > to allow a system to be built in parts to be stitched together later. > > > Diffs > ----- > > src/python/m5/SimObject.py e40b35147270 > src/python/m5/params.py e40b35147270 > src/python/m5/simulate.py e40b35147270 > src/python/m5/stats/__init__.py e40b35147270 > > Diff: http://reviews.gem5.org/r/2246/diff/ > > > Testing > ------- > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
