----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2314/#review5196 -----------------------------------------------------------
Ship it! Thanks for taking the time to fix this! This looks good, I'm happy to have this committed. I'd suggest that you add a line to the commit message saying that this fixes PCI interrupt routing and discovery on Linux. - Andreas Sandberg On July 17, 2014, 6:27 a.m., Jiuyue Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2314/ > ----------------------------------------------------------- > > (Updated July 17, 2014, 6:27 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > config: swap bus_id of ISA/PCI in X86 IntelMPTable > > This patch assign bus_id=0 to PCI bus and bus_id=1 to ISA bus for > X86 platform. Because PCI device get config space address using > Pc::calcPciConfigAddr() which requires "assert(bus==0)". > > > Diffs > ----- > > configs/common/FSConfig.py 878f2f30b12d38f619b80b5d80d52498946f6ad1 > > Diff: http://reviews.gem5.org/r/2314/diff/ > > > Testing > ------- > > > Thanks, > > Jiuyue Ma > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
