----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2321/#review5244 -----------------------------------------------------------
Ship it! Looks good, but I'd appreciate it if you'd list the features you're enabling (and maybe which you don't enable) instead of just listing the features you don't enable. - Andreas Sandberg On Aug. 1, 2014, 4:48 p.m., Alexandru Dutu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2321/ > ----------------------------------------------------------- > > (Updated Aug. 1, 2014, 4:48 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10266:cd09bde69eef > --------------------------- > cpuid, x86: Enabling more features in CPUid > Adding more features in the CPUid with the purpose of supporting running the > KvmCPU in SE mode. > > > Diffs > ----- > > src/arch/x86/cpuid.cc c00b5ba43967e7e48a28b7ddc48c9f4afaf2ab76 > > Diff: http://reviews.gem5.org/r/2321/diff/ > > > Testing > ------- > > Quick regressions passed. > > > Thanks, > > Alexandru Dutu > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
