----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2327/#review5257 -----------------------------------------------------------
src/arch/arm/table_walker.hh <http://reviews.gem5.org/r/2327/#comment4799> Why not map these to 12, 14 and 16? This will eliminate the separate int grainSize variable that is being maintained. To me it seems only one of grain and grainsize is required. src/arch/arm/table_walker.cc <http://reviews.gem5.org/r/2327/#comment4798> GrainSize instead of unsigned. - Nilay Vaish On Aug. 13, 2014, 12:50 p.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2327/ > ----------------------------------------------------------- > > (Updated Aug. 13, 2014, 12:50 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10287:47e83de5d36f > --------------------------- > arm: support 16kb vm granules > > > Diffs > ----- > > src/arch/arm/miscregs.hh 79fde1c67ed8 > src/arch/arm/table_walker.hh 79fde1c67ed8 > src/arch/arm/table_walker.cc 79fde1c67ed8 > > Diff: http://reviews.gem5.org/r/2327/diff/ > > > Testing > ------- > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
