----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2308/#review5265 -----------------------------------------------------------
Pradip, several comments. * If possible, split this patch into smaller ones. * Drop the code that has been commented out. * If possible, do not add a new protocol. Modify the existing one so that it works with and without TSX as well. - Nilay Vaish On July 5, 2014, 3:20 a.m., Pradip Vallathol wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2308/ > ----------------------------------------------------------- > > (Updated July 5, 2014, 3:20 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > The patch adds (partial) support for TSX instructions in gem5. > > Below is the summary of features added: > - 3 new instructions added to X86 ISA: xbegin, xabort and xend > - Added memory level support required by the instructions to the L0 and the > L1 cache. L0 cache maintains the transactional state while L1 helps in > versioning. > - The O3 CPU model has been modified to support the special transactional > requests. Other CPU models are not supported. > - Support for HLE prefixes (XACQUIRE and XRELEASE) have also been provided. > Prefixes for all instructions are not yet supported. But the code to generate > HLE prefixed instructions has been templatized for easy use. > > Acknowledgement: > This work was done as a part of the course Advanced Topics in Computer > Architecture at UW-Madison under Prof. David Wood along with Robin Paul > Prakash and extended during a Masters Project under Prof. David Wood. > > [Resubmitting because first submit failed] > > > Diffs > ----- > > build_opts/X86_MESI_Three_Level PRE-CREATION > build_opts/X86_MESI_Txn_Three_Level PRE-CREATION > configs/common/Options.py 878f2f30b12d > configs/ruby/MESI_Txn_Three_Level.py PRE-CREATION > src/arch/x86/faults.hh 878f2f30b12d > src/arch/x86/faults.cc 878f2f30b12d > src/arch/x86/isa/decoder/locked_ele_opcodes.isa PRE-CREATION > src/arch/x86/isa/decoder/locked_els_opcodes.isa PRE-CREATION > src/arch/x86/isa/decoder/locked_nel_opcodes.isa PRE-CREATION > src/arch/x86/isa/decoder/locked_opcodes.isa 878f2f30b12d > src/arch/x86/isa/decoder/one_byte_opcodes.isa 878f2f30b12d > src/arch/x86/isa/decoder/two_byte_opcodes.isa 878f2f30b12d > src/arch/x86/isa/insts/general_purpose/data_transfer/move.py 878f2f30b12d > src/arch/x86/isa/insts/general_purpose/data_transfer/xchg.py 878f2f30b12d > src/arch/x86/isa/insts/general_purpose/semaphores.py 878f2f30b12d > src/arch/x86/isa/microops/ldstop.isa 878f2f30b12d > src/arch/x86/isa/microops/microops.isa 878f2f30b12d > src/arch/x86/isa/microops/txnop.isa PRE-CREATION > src/arch/x86/linux/syscalls.cc 878f2f30b12d > src/arch/x86/regs/misc.hh 878f2f30b12d > src/cpu/StaticInstFlags.py 878f2f30b12d > src/cpu/base_dyn_inst.hh 878f2f30b12d > src/cpu/o3/commit_impl.hh 878f2f30b12d > src/cpu/o3/fetch_impl.hh 878f2f30b12d > src/cpu/o3/inst_queue_impl.hh 878f2f30b12d > src/cpu/o3/lsq_unit.hh 878f2f30b12d > src/cpu/o3/lsq_unit_impl.hh 878f2f30b12d > src/cpu/static_inst.hh 878f2f30b12d > src/cpu/thread_context.hh 878f2f30b12d > src/mem/packet.hh 878f2f30b12d > src/mem/packet.cc 878f2f30b12d > src/mem/protocol/MESI_Three_Level-msg.sm 878f2f30b12d > src/mem/protocol/MESI_Txn_Three_Level-L0cache.sm PRE-CREATION > src/mem/protocol/MESI_Txn_Three_Level-L1cache.sm PRE-CREATION > src/mem/protocol/MESI_Txn_Three_Level.slicc PRE-CREATION > src/mem/protocol/RubySlicc_Exports.sm 878f2f30b12d > src/mem/protocol/RubySlicc_Types.sm 878f2f30b12d > src/mem/protocol/SConsopts 878f2f30b12d > src/mem/request.hh 878f2f30b12d > src/mem/ruby/slicc_interface/AbstractCacheEntry.hh 878f2f30b12d > src/mem/ruby/slicc_interface/AbstractCacheEntry.cc 878f2f30b12d > src/mem/ruby/slicc_interface/AbstractController.hh 878f2f30b12d > src/mem/ruby/slicc_interface/AbstractController.cc 878f2f30b12d > src/mem/ruby/system/CacheMemory.hh 878f2f30b12d > src/mem/ruby/system/CacheMemory.cc 878f2f30b12d > src/mem/ruby/system/RubyPort.hh 878f2f30b12d > src/mem/ruby/system/RubyPort.cc 878f2f30b12d > src/mem/ruby/system/Sequencer.hh 878f2f30b12d > src/mem/ruby/system/Sequencer.cc 878f2f30b12d > src/mem/ruby/system/TBETable.hh 878f2f30b12d > > Diff: http://reviews.gem5.org/r/2308/diff/ > > > Testing > ------- > > Testing was done using a set of microbenchmarks written during the > development phase and also using the STAMP benchmark suite which was modified > to use the TSX instructions. > [The microbenchmarks used to test the implementation is attached] > > > File Attachments > ---------------- > > Microbenchmarks used for testing > http://reviews.gem5.org/media/uploaded/files/2014/07/05/tsx_tests.zip > > > Thanks, > > Pradip Vallathol > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
